Skip to content

Package index is now downloaded automatically when is required #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Aug 19, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

update

  • What is the current behavior?

When users run a command requiring package_index.json to be already there (for example core install arduino:[email protected]) the CLI was giving this error: Error installing: There were errors loading platform indexes
#792

  • What is the new behavior?

Now it should download automatically the package_index.json when it's not already in place and it is required by the command the user is running.

  • Does this PR introduce a breaking change?

no, the user can still use core update-index

  • Other information:

See how to contribute

@umbynos umbynos requested a review from a team August 19, 2020 15:24
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants